search

jfrog / charts

JFrog official Helm Charts
https://jfrog.com/integration/helm-repository/
Apache License 2.0
255 stars 444 forks source link

[xray] Feature Request: Ability to define LoadBalancer IP of Xray service #1304

Closed broomyocymru closed 3 years ago

broomyocymru commented 3 years ago

Currently there is no way to define a static load balancer ip on the xray service template xray-svc.yaml, an optional param server.service.loadBalancerIP would resolve this. Our use case is to provide internal private address on an Azure AKS.

server:
  service:
    type: LoadBalancer
    name: xray
    loadBalancerIP: 192.103.67.51
    annotations:
      "service.beta.kubernetes.io/azure-load-balancer-internal": "true"

Alternatively providing an additionalSpec field that accepted yaml may provide a more generic solution.

server:
  service:
    additionalSpec: |
         loadBalancerIP: 192.103.67.51
         customKey: customVal
chukka commented 3 years ago

@broomyocymru can you share more details on this like xray chart version ?

broomyocymru commented 3 years ago

Xray helm chart version 6.6.0 with Xray 3.13.0.

rahulsadanandan commented 3 years ago

Hi @broomyocymru We have discussed and created a ticket internally for this. We will have this solution implemented soon. Thanks.

rahulsadanandan commented 3 years ago

@broomyocymru Can you please review the pr for additionalSpec. https://github.com/jfrog/charts/pull/1339/files

broomyocymru commented 3 years ago

Hey @rahulsadanandan , I've successfully used the fix with the latest release. Thanks for the assistance