jfrog / charts

JFrog official Helm Charts
https://jfrog.com/integration/helm-repository/
Apache License 2.0
260 stars 447 forks source link

[jfrog-platform] chart doesn't work with just `rabbitmq:enabled: false` #1794

Closed kmorkans closed 1 year ago

kmorkans commented 1 year ago

Version of Helm and Kubernetes:

Testing on minikube v1.30.1 and Helm v3.12.2

Which chart:

jfrog-platform

What happened:

jfrog-platform chart doesn't work with just rabbitmq:enabled: false. Needed to provide rabbitmq:migration:enabled: false and rabbitmq:rabbitmqUpgradeReady: true as well. Got error - Helm install failed: template: jfrog-platform/templates/migration-hook.yaml:80:16: executing "jfrog-platform/templates/migration-hook.yaml" at <.Values.rabbitmq.podSecurityContext.enabled>: nil pointer evaluating interface {}.enabled

Possible fix was added to stable/jfrog-platform/templates/migration-hook.yaml in 10.12.3 release but that was reverted in 10.13.0 release

What you expected to happen:

As per default values file I expected just to be able to set rabbitmq:enabled: false.

How to reproduce it (as minimally and precisely as possible):

Try and install jfrog-platform chart with just rabbitmq:enabled: false.

Anything else we need to know:

chukka commented 1 year ago

@kmorkans Thanks for reporting , this will be fixed ASAP

chukka commented 1 year ago

Fixed in 10.14.2

kmorkans commented 1 year ago

That's great. Thanks!