jfrog / charts

JFrog official Helm Charts
https://jfrog.com/integration/helm-repository/
Apache License 2.0
260 stars 447 forks source link

[Xray] RabbitMQ migration hook should respect global.imageRegistry #1816

Closed Atchuu closed 6 months ago

Atchuu commented 1 year ago

Is this a request for help?: No


Is this a BUG REPORT or FEATURE REQUEST? (choose one): Bug

Version of Helm and Kubernetes:

Helm 3.11.0 / Kubernetes 1.24.9

Which chart:

Xray 103.81.8

Which product license (Enterprise/Pro/oss):

Enterprise

JFrog support reference (if already raised with support team):

What happened:

Inside our air-gapped network, an upgrade of Xray with mostly default settings attempts to trigger the pre-upgrade-hook. That template has a hardcoded value for the hooks image's registry path. This is a problem for environments where the Kubernetes nodes cannot reach releases-docker.jfrog.io.

What you expected to happen:

The setting for global.imageRegistry (or something else) should be respected and the pre-upgrade-hook container can pull and start

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know:

chukka commented 1 year ago

Yes, it's fixed internally, will be released in next few weeks (103.83.x mostly)

rahulsadanandan commented 6 months ago

This fix is available in the latest onprem charts 103.95.7