search

jfrog / charts

JFrog official Helm Charts
https://jfrog.com/integration/helm-repository/
Apache License 2.0
254 stars 439 forks source link

Useless Values definition maxOpenConnections #1817

Closed Amir-Wollman closed 11 months ago

Amir-Wollman commented 11 months ago

Unless I'm missing something, it would seem as though Values.yaml in artifactory chart defines value maxOpenConnections in database, tomcat and nginx.

However, there are no consumers of it in the templates themselves hence these values are not in use.

search results in code search: https://github.com/search?q=repo%3Ajfrog%2Fcharts%20maxOpenConnection&type=code

Chart location: https://github.com/jfrog/charts/tree/721428f2f1b4e1c35940cd4bf71f712e954fd902/stable/artifactory

Amir-Wollman commented 11 months ago

NVM - I see that these are included as a templated values file