jfrog / charts

JFrog official Helm Charts
https://jfrog.com/integration/helm-repository/
Apache License 2.0
254 stars 439 forks source link

[Xray] Add ability to configure defaultRetentionDaysForIndexedRepo for Xray #1832

Closed gregoryboue closed 1 month ago

gregoryboue commented 10 months ago

Is this a request for help?: No


Is this a BUG REPORT or FEATURE REQUEST? (choose one): FEATURE REQUEST

Currently the Xray indexing default retention period can be defined in Xray System yaml with server.repo.defaultRetentionDaysForIndexedRepo settings.

If we want to configure this settings, we have to override xray system yaml (see systemYamlOverride), so it would be great to be able to configure this setting via a value in the chart's values.yaml file.

rahulsadanandan commented 1 month ago

@gregoryboue Recently have merged a feature (https://github.com/jfrog/charts/pull/1842) that allows overriding the system YAML with the extraSystemYaml section. The entries specified under ‘xray.extraSystemYaml’ will be merged with files/system.yaml to generate the final system.yaml.

https://github.com/jfrog/charts/blob/master/stable/xray/values.yaml#L192-L202

Let us know if this works for you.