jfrog / charts

JFrog official Helm Charts
https://jfrog.com/integration/helm-repository/
Apache License 2.0
260 stars 447 forks source link

[xray] Fix containerSecurityContext with loggers in StatefulState template #1837

Closed jbblache closed 3 months ago

jbblache commented 1 year ago

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Fix containerSecurityContext on loggers since we are in a range. The .Values.containerSecurityContext.enabled is not found and replaced. The "$" fixes the problem.

Special notes for your reviewer:

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

jbblache commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

rahulsadanandan commented 1 year ago

@jbblache Thank you for the pull request. We've incorporated it internally and it will roll out with the 3.86.x versions of xray.

oumkale commented 3 months ago

Hi @jbblache,

Kudos to you, Thank you so much for this PR.

We have released this in Xray version 3.86.1.