jfrog / charts

JFrog official Helm Charts
https://jfrog.com/integration/helm-repository/
Apache License 2.0
260 stars 447 forks source link

[xray]Added support for service account annotations #1841

Closed evanshoshan closed 1 month ago

evanshoshan commented 1 year ago

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

What this PR does / why we need it:

This PR allows for the configuring of service account annotations.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


0 out of 2 committers have signed the CLA.
:x: @Evan Shoshan
:x: @megha1906
Evan Shoshan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

evanshoshan commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

evanshoshan commented 12 months ago

recheck

evanshoshan commented 11 months ago

I have read the CLA Document and I hereby sign the CLA

rhys96 commented 4 months ago

This would be very helpful, I'm having to create my own Service Account to add annotations. Is anyone from JFrog able to give an update?

megha1906 commented 4 months ago

@evanshoshan Thanks for the PR. We will check this internally and will fix this in the upcoming versions of Xray. cc @rahulsadanandan

megha1906 commented 1 month ago

HI @evanshoshan ,we will be releasing this change in Xray version 3.105.x