Closed NiklasRosenstein closed 11 months ago
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅
I have read the CLA Document and I hereby sign the CLA
recheck
Seems this is also needed for startupProbe, and the path appears incorrect as well (/artifactory/system/rtfs/ping
instead of /rtfs/ping
)
Hi @NiklasRosenstein . Thank you for this PR, but this service is actually not production ready and should not even be enabled.
The current federation functionality still runs in Artifactory.
Simply disable this service (federation.enabled=false
) and ignore it.
The probes will be replaced with formal liveness
and readiness
as in other services when this service comes out officially.
I'm closing this PR for now. Let us know if you require any further assistance.
Gotcha, thanks @eldada! I'm early into getting Artifactory set up and mistakenly assumed this service needs to run for Access Federation to work, although I had not tried it without yet.
PR Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[artifactory]
)What this PR does / why we need it:
It appears the
/rtfs/sync/ping
endpoint must be hit with aPOST
request instead of aGET
request.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: