[artifactory-ha] Fix missing volume on member nodes when using gcpServiceAccount.customSecretName

jfrog / charts

JFrog official Helm Charts

https://jfrog.com/integration/helm-repository/

Apache License 2.0

249 stars 436 forks source link

[artifactory-ha] Fix missing volume on member nodes when using gcpServiceAccount.customSecretName #1878

Closed agunnerson-elastic closed 2 months ago

agunnerson-elastic commented 2 months ago

Previously, only the volumeMount was created, but not the volume itself. This affected only member nodes, not primary nodes.

Fixes: https://github.com/jfrog/charts/issues/1873

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] Chart Version bumped
[x] CHANGELOG.md updated
[x] Title of the PR starts with chart name (e.g. [artifactory])

github-actions[bot] commented 2 months ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

_{You can retrigger this bot by commenting recheck in this Pull Request}

agunnerson-elastic commented 2 months ago

^^ I'm waiting to get approval from my employer for signing the CLA. I'll post here once I get an update on that.

oumkale commented 2 months ago

Hi @agunnerson-elastic,

Thank you for your PR, we have already taken this internally and it will be released in upcoming release 7.84.x

Will keep you updated

oumkale commented 2 months ago

Hi @agunnerson-elastic,

We really appreciate your efforts and are happy to inform you that your changes have been taken internally and released in 107.84.10