jfrog / charts

JFrog official Helm Charts
https://jfrog.com/integration/helm-repository/
Apache License 2.0
259 stars 448 forks source link

wrong copy-circle-of-trust-certificates imagePullPolicy configuration #1881

Closed Kebree closed 6 months ago

Kebree commented 6 months ago

Version of Helm and Kubernetes: All

Which chart: Since 107.84.10

Which product license (Enterprise/Pro/oss): All

What happened:

Following the release of the latest update, the ha statefulset went from :

     - name: copy-circle-of-trust-certificates
        image: {{ include "artifactory-ha.getImageInfoByValue" (list . "initContainers") }}

to :

  - name: copy-circle-of-trust-certificates
        image: "{{ .Values.initContainerImage }}"
        imagePullPolicy: c

What you expected to happen:

The image pull policy cannot be 'c'

chukka commented 6 months ago

@Kebree can you please share reproducible steps ? .Values.initContainerImage is depreciated in 107.84.10 version

Kebree commented 6 months ago

Sorry, wrong paste from my part, the stable/artifactory-ha/templates/artifactory-primary-service.yaml file went from

 - name: copy-circle-of-trust-certificates
       image: "{{ .Values.initContainerImage }}"

to

 - name: copy-circle-of-trust-certificates
       image: {{ include "artifactory-ha.getImageInfoByValue" (list . "initContainers") }}
       imagePullPolicy: c

but anyway, the issue is not on the "image" part but on the "imagePullPolicy" part.

The reproducible step is setting the artifactory.circleOfTrustCertificatesSecret value.

chukka commented 6 months ago

Thanks

chukka commented 6 months ago

This has been fixed internally and will be available for next patch release

chukka commented 6 months ago

@Kebree Please try 107.84.11 chart for the fix and share feedback

Kebree commented 6 months ago

Services are starting now. Thank you for the resolution of this issue.