jfrog / charts

JFrog official Helm Charts
https://jfrog.com/integration/helm-repository/
Apache License 2.0
259 stars 448 forks source link

[artifactory-ha] set as version value after the last colon #1892

Closed malamin closed 3 months ago

malamin commented 5 months ago

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

What this PR does / why we need it: incorrect value is set as a chart version when images are downloaded from DNS containing the port number, which makes helm deployment impossible without fixing the chart with kustomize (e.g. in case of 'test.jfrog.io:8085/example:123' in the artifactory-ha statefulset the version is set as '8085/example' instead of '123')

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

github-actions[bot] commented 5 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

malamin commented 5 months ago

I have read the CLA Document and I hereby sign the CLA

malamin commented 5 months ago

recheck

oumkale commented 5 months ago

Hi @malamin,

Thank you reporting this issue, we have taken this internally. We will fix this in upcoming release and update you

dosilyoun commented 4 months ago

image Looks like the fix was released with version 107.84.16

chukka commented 3 months ago

fixed via #1907