search

jfrog / charts

JFrog official Helm Charts
https://jfrog.com/integration/helm-repository/
Apache License 2.0
259 stars 448 forks source link

artifactory - Fix for ClusterIP type service with external ingress offloading #1906

Closed fwdIT closed 3 weeks ago

fwdIT commented 3 months ago

Fixes current helm chart limitations for external ingress with nginx ClusterIP service type and https / tls offloading on external ingress

In our case basic OpenShift 4.12.x install where the ingress is not the standard nginx which comes with the helm install

PR Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

What this PR does / why we need it: Support for OpenShift type installations

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes # fixes # 308262 (support case @ JFrog)

Special notes for your reviewer: discussed with ashrafk@jfrog.com

github-actions[bot] commented 3 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

fwdIT commented 3 months ago

I have read the CLA Document and I hereby sign the CLA

oumkale commented 3 months ago

Hi @fwdIT,

Thank you for raising PR, we will take this internally and fix this in upcoming releases.

We will update you

fwdIT commented 1 month ago

Any update on this? For us it won't be optimal to start with manually tweaked upstream helm charts for our automated installation. During the POC, this was no issue. We however now, since we are licensed, need to automate the install and we don't want to use custom adjusted vendor helm charts for this. We should only need to adjust the values, not the logic.

RobinDuhan commented 1 month ago

@fwdIT We have taken this, and it will be released tentatively by third week of October. I have raised another PR on top of your changes - https://github.com/jfrog/charts/pull/1926 - please test and verify if this works for your use case.

RobinDuhan commented 1 month ago

@fwdIT Reminder to review

fwdIT commented 1 month ago

@RobinDuhan sorry for the delay, looks fine by me took a dry run from my previous code and again from your commit and aside from some new blocks, like jfrog-platform-artifactory-configmaps (and some parts in comments), minor image version changes, the main parts and certainly the nginx part stays identical and what is needed to work on OpenShift

thx for the tweaks and additions! this will help us not needing to use manually adjusted helm charts like today

looking forward to the release

RobinDuhan commented 1 month ago

@fwdIT Great, thank you for verifying this at your end as well.

fwdIT commented 1 month ago

@RobinDuhan when will this #1926 be merged and present in the main repo? We are planning to automate our installation and would need this from upstream helm charts rather and tweaked helm charts which only live on our end?

RobinDuhan commented 1 month ago

@fwdIT This is taken with the ongoing release. This will tentatively be available by mid-end next week.