search

jfrog / cocoapods-art

CocoaPods Plugin to work against Artifactory Repository
Apache License 2.0
58 stars 27 forks source link

netrc optional change #19

Closed marchinram closed 6 years ago

marchinram commented 6 years ago

Clone of https://github.com/JFrogDev/cocoapods-art/pull/12 Working with employer to get CLA signed should hopefully have this early next week

eyalbe4 commented 6 years ago

Thanks @marchinram. Please let us know when the CLA is signed and we'll merge this.

marchinram commented 6 years ago

@eyalbe4 I got approval for this, however the person who will sign cla may have different email than mine, is that ok?

marchinram commented 6 years ago

@eyalbe4 The CLA has been signed, the signer's name is Matt Kamen, did you receive? Or does it need to be manually sent?

eyalbe4 commented 6 years ago

@marchinram, I'm afraid the CLA must be signed with the same github email address and name of the committer... You can either ask the person who signed the CLA to submit a new pull request or sign the CLA.

marchinram commented 6 years ago

@eyalbe4 I signed CLA do you receive automatically or do I need to email you?

eyalbe4 commented 6 years ago

Thanks @marchinram. We'll soon publish a new release.

eyalbe4 commented 6 years ago

cocoapods-art 1.0.1 is has been published.

kylefowler commented 6 years ago

hey @eyalbe4. Thanks for merging this. We realized after the merge that this only solved the first half of the issue which was pulling the podspecs from artifactory. We didn't realize that the artifactory server was the one putting in the source line to the podspec and at that point it doesnt include any credentials. So now pod install is failing because the source file doesnt have the authentication information that was now added in the repo add step.

The solution seems to be modifying the source line of the downloaded podspec and including the credentials from the stored repo url. I cant decide if that feels hacky or necessary. Any thoughts?

eyalbe4 commented 6 years ago

Hi @kylefowler, Question: Can you store the credentials in the .netrc file, as shown in the README?

kylefowler commented 6 years ago

I personally could yeah, we were just trying to avoid the .netrc file since we are distributing the pod in question to external parties. The .netrc file seemed like an excessive step to request that they modify their environment outside of the project workspace for this to work. It definitely appears as if it will be the only solution for now.