Closed sphanley closed 3 years ago
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅
I have read the CLA Document and I hereby sign the CLA
Hello @yahavi - sorry to ping you, but I see you're the most recently active maintainer of this project. Any chance that someone could give this a quick review? It would be extremely helpful to my team if this could be merged and included in a future release.
Thanks for this contribution @sphanley and apologies for the late response. Would you mind documenting this in the README as well?
@eyalbe4 thanks for the reply - updated the README, please let me know if there's anything else needed to prepare this for a merge.
Hey again @eyalbe4 - any chance you can confirm if this meets what you were looking for, and if there's anything else I can do to get it merged? My team would really benefit from having this in an upcoming release.
Hate to be a bother, but my team is still hoping we can see this merged, or that I can get more feedback on any other changes which might be needed.
Sure @sphanley - this PR is approved. Please go ahead and resolve the conflicts, and we'll merge this PR and release a new version.
@eyalbe4 thanks so much for getting this merged for me! I appreciate it!
Hello @eyalbe4! Just wanted to see if we can get any info on when the next release of this plugin might happen? We'd love to know when we can expect a released version containing this change now that it's merged. Thanks!
Hey @sphanley - cocoapods-art 1.1.0 has just been released. Thanks again for your involvement and contribution.
This PR implements an option to store the Artifactory username and password in an environment variable, rather than in a file on disk. The current implementation of cocoapods-art does not support reading credentials from environment variables, instead requiring credentials to be hard-coded into the
.netrc
file.With this change, if the
COCOAPODS_ART_CREDENTIALS
variable is set, its value will be passed via the--user
flag, consistent with the way that the project will currently pass the value ofCOCOAPODS_ART_NETRC_PATH
via--netrc-file
if set. Per the Curl manpage, the--user
flag "Overrides -n, --netrc and --netrc-optional", so this will take precedence over the existing credentials implementation if used, without requiring any additional logic to switch between the two approaches.