jfrog / frogbot

🐸 Scans your Git repository with JFrog Xray for security vulnerabilities. 🤖
https://docs.jfrog-applications.jfrog.io/
Apache License 2.0
305 stars 73 forks source link

Updating UpdateDependency test for all package managers + tests fixes #669

Closed eranturgeman closed 7 months ago

eranturgeman commented 8 months ago
github-actions[bot] commented 7 months ago
[![👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerPR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)

[🐸 JFrog Frogbot](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)
eranturgeman commented 7 months ago

Looks great! Just note that the previous tests also covered the whole "find descriptor file" process per technology, and if you'd like to do more of an integration test, this functionality should be checked as well.

Thanks @EyalDelarea ! I unified all the "find descriptor files" functions for the different PMs into a single function that is being checked separately. This change and new test were introduced in this PR: https://github.com/jfrog/frogbot/pull/656 Therefore I could take it our from the test that checks every PM