jfrog / gocenter

The Github README for JFrog Go-center. Use this for reporting issues
https://gocenter.io
Apache License 2.0
164 stars 23 forks source link

Lack of Windows hints in setting up gocenter #3

Closed glennsarti closed 5 years ago

glennsarti commented 5 years ago

Both the To use GoCenter: and Set Me Up sections are *nix / Mac focused. These instructions will not work on Windows. Given Go is cross platform, shouldn't there be instructions for Windows users too?

Piping to sh (or curl either really) won't work

image

Using export won't work

image


To help us debug your issue please confirm the following :

elioengcomp commented 5 years ago

Hi @glennsarti,

Thanks for you feedback.

We are discussing this change with the UI team.

In the meantime, you can find instructions on how to setup goc on Windows at the goc GitHub Page, by following the Download Directly From Bintray section.

glennsarti commented 5 years ago

Thanks @elioengcomp . This might be out of scope for this particular issue, but the windows binary goc.exe is missing a lot of identifying information and isn't digitally signed. While consumers may not care so much, I know many Windows enterprise-y people will look at this and immediately be suspicious of it. Particularly AV products will flag unsigned/random looking exe's.

image

elioengcomp commented 5 years ago

Hi @glennsarti

Thank you for pointing that out.

I have opened a new issue about it on the goc project.

elioengcomp commented 5 years ago

We have added instructions on how to download goc for Windows in the goc README.

We still plan to update the UI later on, that is why this issue is still open.

elioengcomp commented 5 years ago

Windows instructions were added to the UI.

JFrog_GoCenter_-_The_Central_Go_Modules_Repository

ankushchadha commented 5 years ago

Hi @glennsarti - With the new set of changes in GoCenter, there is no reason to use goc anymore.

Once the GOPROXY is set to https://gocenter.io, GoCenter will be able to serve modules and avoid 404s for valid modules even if they don't exist in GoCenter.

glennsarti commented 5 years ago

Thanks @elioengcomp !!