search

jfrog / jenkins-artifactory-plugin

Jenkins artifactory plugin
http://jenkins-ci.org/
114 stars 186 forks source link

Publishing a build when the commit message includes a '/' character causes a 400 error #827

Closed jakegt1 closed 10 months ago

jakegt1 commented 1 year ago

Describe the bug Publishing a build when the commit message includes a '/' character causes a 400 error as it is incorrectly escapes.

To Reproduce git commit -m "My commit message with a /" push to branch deploy fails - <!doctype html><html lang="en"><head><title>HTTP Status 400 – Bad Request</title><style type="text/css">body {font-family:Tahoma,Arial,sans-serif;} h1, h2, h3, b {color:white;background-color:#525D76;} h1 {font-size:22px;} h2 {font-size:16px;} h3 {font-size:14px;} p {font-size:12px;} a {color:black;} .line {height:1px;background-color:#525D76;border:none;}</style></head><body><h1>HTTP Status 400 – Bad Request</h1></body></html>

Expected behavior deploy passes

Screenshots

Versions

Additional context Caused by https://github.com/jfrog/jenkins-artifactory-plugin/commit/c69421055a4f2e0cc6bf87caa1a7b6911aa9e84c

wzur-r3 commented 1 year ago

Experiencing exactly the same problem, see https://github.com/jfrog/jenkins-artifactory-plugin/issues/737#issuecomment-1582690235

davies147 commented 1 year ago

+1 I am having the same issue with / # ( and ) characters in vcs.message strings, and that is used as part of common PR merge pattern. eg Merge pull request #1826 from repo/project or My PR being merged (PR#1826)

gmckerrell commented 1 year ago

+1 same issue here default github commit messages are being rejected by artifactory server.

davies147 commented 1 year ago

This issue appears to have been caused by the following version 3.8.13 change:

Bug Fix - Escape non-ascii and more special characters in vcs properties (https://github.com/jfrog/jenkins-artifactory-plugin/issues/737) by @julian-computes in https://github.com/jfrog/jenkins-artifactory-plugin/pull/765

julian-computes commented 1 year ago

I think you’re right @davies147. Apologies. My change should be reverted.

yahavi commented 1 year ago

@davies147 @jakegt1 @gmckerrell @wzur-r3 @julian-computes We released Jenkins Artifactory plugin 3.18.9. This version includes @julian-computes's fix https://github.com/jfrog/jenkins-artifactory-plugin/pull/851.

Feel free to upgrade. We'd appreciate your feedback on that!

jakegt1 commented 10 months ago

thanks, all good