jfrog / jenkins-artifactory-plugin

Jenkins artifactory plugin
http://jenkins-ci.org/
114 stars 186 forks source link

Publishing causes a 400 error when a semi-colon is in the the commit message. #831

Open dbrunkow opened 1 year ago

dbrunkow commented 1 year ago

Describe the bug When committing from our code repository, if we add a semi-colon in the message, the deploy fails.

To Reproduce Commit message "Jenkinsfile edited online with Bitbucket ; \hello: Run maven Jenkinsfile build results in "errors" : [ { "status" : 400, "message" : "Property key: +%5Chello is invalid due to Name must start with a letter and cannot contain whitespace or special characters" PUT product-lib/sample/0.0.2-SNAPSHOT/sample-0.0.2-SNAPSHOT.jar;vcs.revision=98554d9a670f31315c8a06fc94e54bddf5f6325e;build.timestamp=1687373009948;build.name=prism-test;build.number=34;vcs.branch=maven;vcs.url=ssh%3A%2F%2Fgit%40bitbucket.company.com%3A7999%2Fcompany.2Fsample.git;vcs.message=Jenkinsfile+edited+online+with+Bitbucket+%3B+%5Chello HTTP/1.1

Expected behavior Commit message should not impact the artifact upload. Artifact should deploy.

Screenshots If applicable, add screenshots to help explain your problem.

Versions

Additional context We're seeing other issues with forward slashes on 3.18.4 as well which I'll create an issue for.

yahavi commented 1 year ago

@dbrunkow We released Jenkins Artifactory plugin 3.18.9. This version has the following fix https://github.com/jfrog/jenkins-artifactory-plugin/pull/851, which should resolve the issue with the forward slashes. This version also includes https://github.com/jfrog/jenkins-artifactory-plugin/pull/756 which included since 3.18.1 that escape the semi-colon character.

Feel free to upgrade. We'd appreciate your feedback on that.