search

jfrog / jenkins-artifactory-plugin

Jenkins artifactory plugin
http://jenkins-ci.org/
114 stars 186 forks source link

Use jersey2-api for jersey jars #838

Closed jakegt1 closed 5 months ago

jakegt1 commented 1 year ago

Closes #735

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

jakegt1 commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

jakegt1 commented 1 year ago

Have ran the unit tests and they are fine. This is a pretty helpful change as otherwise artifactory plugin conflicts with Gitlab plugin.

jakegt1 commented 1 year ago

Also, this uses a relatively old version of jersey2-api. These will be picked up by runtime, so it doesn't cause much issue in actual systems (will just use whatever jenkins is using.) However, going to a newer version requires massive changes to the pom (need to upgrade the plugin pom from 3.57 -> 4.xx), which is a lot more work then just doing above.

jakegt1 commented 1 year ago

Not sure what i am supposed to do here, will anyone review this?

jakegt1 commented 1 year ago

@eyalbe4 how are these tests set up? Is there a list of plugins that get installed, because if the jersey2-api plugin isn't in the plugins list i would guess this would fail.

jakegt1 commented 1 year ago

assuming you're using something like plugins.txt.

jakegt1 commented 1 year ago

Any help here? Not sure how i can solve this problem if the problem is just a missing dependency in the target test jenkins instance.

jakegt1 commented 1 year ago

Anyone? I am still quite sure this is just because the target jenkins instance does not include jersey2-api.

jakegt1 commented 1 year ago

Still don't know what i can do here..

jakegt1 commented 11 months ago

@eyalbe4, sorry if this is the wrong person but I would really like this in. It's enough of a pain for me that i currently have to maintain a fork of the plugin.

jakegt1 commented 11 months ago

as I said earlier, my guess is this is now failing because the plugins.txt used in the jenkins instance does not include jersey2-api.

banholzer commented 7 months ago

As we see the very same issue here, can anybody please pick this up?

jakegt1 commented 7 months ago

I just maintain my own version now because I didn't get a response sadly

RobiNino commented 5 months ago

Hi @jakegt1 , We apologies for the delay and lack of communication here. After we fixed our testing suite we're ready to merge this along with a few dependencies that had to be upgraded with jersey in #927 . Thanks a lot for your contribution!

jakegt1 commented 5 months ago

@RobiNino is fine, I have worked around it for a while with my own fork anyway, but good for me to not need to maintain it anymore lol. Thanks!