search

jfrog / jenkins-artifactory-plugin

Jenkins artifactory plugin
http://jenkins-ci.org/
114 stars 186 forks source link

Modernize to latest versions supported by Java 8 #841

Open sghill-rewrite opened 1 year ago

sghill-rewrite commented 1 year ago

Hi!

This PR aims to modernize tooling and move this plugin closer to the recommended Jenkins baseline version without making the change too big. If this goes well, I can follow up with a subsequent PR to modernize further.

This PR was generated with an OpenRewrite recipe on Moderne.io.

Additionally I enabled maven enforcer by adding the required excludes and relying on the parent POM's enforcer config.

github-actions[bot] commented 1 year ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

sghill commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

sghill-rewrite commented 1 year ago

I have read the CLA Document and I hereby sign the CLA

sghill-rewrite commented 1 year ago

recheck

sghill commented 1 year ago

@yahavi I saw you merged a recent PR, would you be able to look at this one or point me to someone who could?

It'd be great to modernize this important plugin so it didn't install so many implicit plugin dependencies

jonesbusy commented 1 year ago

I think this PR could have been prevented https://github.com/jfrog/jenkins-artifactory-plugin/issues/845

yahavi commented 1 year ago

@sghill-rewrite Thanks for this contribution!

It looks like some of the integration tests are failing with:

Error: Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/http/client/methods/HttpUriRequest

sghill commented 1 year ago

Thanks for taking a look @yahavi!

Looks like these integration tests require some extra setup. Any advice on running them locally so I can debug?

I was able to run some of the DeclarativeITest suite setup locally, but most tests were skipped due to missing environment variables. I suppose those need to point to running services?

I did notice the logs included that parameterized-trigger must be updated to run with the git plugin, but I don't see parameterized-trigger referenced in the project.

sghill commented 1 year ago

Related to #847

rahulsom commented 1 year ago

Hey @sghill! I was trying to change as little as possible on my PR. I thought I would rewrite the integration tests to use test containers instead of relying on running local services.

sghill commented 1 year ago

Sounds great @rahulsom! Happy to rebase here when that's ready or break this down into smaller PRs