jfrog / jenkins-artifactory-plugin

Jenkins artifactory plugin
http://jenkins-ci.org/
114 stars 187 forks source link

plugin kitchen-sink dependencies do not work as expected #933

Open jtnord opened 4 months ago

jtnord commented 4 months ago

Describe the bug

the plugin is bundling the kitchen sink inside the plugin's HPI. Many of these dependencies come from Jenkins core, or are also bundle in non optioanl plugins that this plugin depends on.

in the case the dependency comes from Jenkins core or a non optional dependencies this is just a waste of disk space.

in the case the dependency is also coming from an optional plugin then the plugin may well blow up at runtime, or exhibit different behaviour as the version bundled in the plugin would be used in some installations and not others.

For example the plugin bundles several apache-commons libraries that come from core and are a waste of space. it also bundles an old version of svnkit that will be used so long as the subversion plugin is not installed, but when it is installed the newer version would be used.

To Reproduce

mvn package -DskipTests inspect the hpi's WEB-INF\lib directory

Expected behavior

there are no libraries bundled that come from Jenkins core, or non optional dependencies.

Screenshots If applicable, add screenshots to help explain your problem.

Versions

Additional context Add any other context about the problem here.