fix bundling of eddsa - Githubissues

jtnord commented 4 months ago

plugin was bundling eddsa which is now a plugin and should be used instead.

whilst looking to fix this the dependencies where a bit of a mess and the plugin build (parent) obsolete and unsupported.

this is a partial fix for this (there is more outstanding) and it has had zero testing other than unit tests are fixed and there are less things bundled in the HPI that are obviously wrong.

the p4 code would not have even worked on a recent version of the perforce plugin as the APIs called where gone. I have adjusted the code so that it may work however other than it compiles and looks about right no testing has been performed.

fixes: #934 partially addresses: #933

[x] This pull request is created in the jfrog/jenkins-artifactory-plugin repository.
[x] All tests passed. If this feature is not already covered by the tests, I added new tests.
[x] All static analysis checks that are not broken hava passed.

github-actions[bot] commented 4 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

jtnord commented 4 months ago

I have read the CLA Document and I hereby sign the CLA

jtnord commented 4 months ago

frogbot appears to be broken, and is not something I can fix in this PR as it is an action to which I have no access to update. guess it needs to be updated to use Java11 runtime (which is needed by maven hpi plugin, which is needed by every Jenkins plugin using a recent toolchain).

it can not work out the packaging of type HPI, yet maven and JDK11 is completely happy with it.

If frogbot and SCA are not happy with the versions used here, I have no idea how they can be happy with the previously historic versions used.

jfrog / jenkins-artifactory-plugin

fix bundling of eddsa #935

[x] All static analysis checks that are not broken hava passed.