search

jfrog / jenkins-jfrog-plugin

Easy integration between Jenkins and the JFrog Platform.
https://github.com/jfrog/jenkins-jfrog-plugin
Apache License 2.0
39 stars 17 forks source link

fix artifactory-installer #11

Closed nekator closed 1 year ago

nekator commented 1 year ago

use credentialID instead of serverId to get credentials from jenkins. Configure version via manage tools

gailazar300 commented 1 year ago

@nekator Thank you for opening this PR - we will review it soon!

yahavi commented 1 year ago

Thanks for this contribution @nekator! Is this PR still relevant? If so, would you like to fix the conflicts and reformat the code?

yahavi commented 1 year ago

@nekator I believe this PR is already covered by https://github.com/jfrog/jenkins-jfrog-plugin/pull/35, https://github.com/jfrog/jenkins-jfrog-plugin/pull/36 & https://github.com/jfrog/jenkins-jfrog-plugin/pull/17.

I'm closing this PR, but please feel free to open a new one if you think that something is missing.