jfrog / jfrog-azure-devops-extension

Apache License 2.0
48 stars 66 forks source link

Artifactory Nuget Push Fails on Extension Version 1.10.2 #184

Open MichaelDenwood opened 4 years ago

MichaelDenwood commented 4 years ago

Describe the bug Artifactory Nuget Push Fails on Extension Version 1.10.2 invalid character '\x00' looking for beginning of value

To Reproduce Steps to reproduce the behavior

artiissue

Expected behavior The package should upload without error.

Screenshots Executing cliCommand: F:\Agents\SaaSProdW1_work_tool\jfrog\1.38.4\x64\jfrog.exe rt u F:\Agents\SaaSProdW1\_work\55\a\*.nupkg nuget-hosted-phx --url="https://artifacts.xx.com/artifactory" --user= --password= [Error] invalid character '\x00' looking for beginning of value

Versions

Additional context Add any other context about the problem here.

yahavi commented 4 years ago

Thanks for reporting this issue, @MichaelDenwood! We couldn't reproduce this issue. I used the project-examples repository and the following configuration:

trigger: none 

pool:
  vmImage: 'windows-latest'

steps:
- task: NuGetToolInstaller@1
- task: ArtifactoryNuGet@2
  inputs:
    command: 'restore'
    artifactoryService: 'ecosys'
    targetResolveRepo: 'nuget'
    solutionPath: '**/*.sln'
    packagesDirectory: '$(Build.ArtifactStagingDirectory)'
    collectBuildInfo: true
    buildName: '$(Build.DefinitionName)'
    buildNumber: '$(Build.BuildNumber)'
    includeEnvVars: true
- task: ArtifactoryNuGet@2
  inputs:
    command: 'push'
    artifactoryService: 'ecosys'
    targetDeployRepo: 'nuget'
    pathToNupkg: '$(Build.ArtifactStagingDirectory)\*.nupkg'
    collectBuildInfo: true
    buildName: '$(Build.DefinitionName)'
    buildNumber: '$(Build.BuildNumber)'
    includeEnvVars: true
- task: ArtifactoryPublishBuildInfo@1
  inputs:
    artifactoryService: 'ecosys'
    buildName: '$(Build.DefinitionName)'
    buildNumber: '$(Build.BuildNumber)'

The Artifactory NuGet push searches for .nupkg files and uploads them by jfrog rt u command. Can you please try, for the experiment, to upload the problematic package using the jfrog cli task? Something like this:

- task: JfrogCli@1
  inputs:
    artifactoryService: 'ecosys'
    command: 'jfrog rt u F:\Agents\SaaSProdW1\_work\55\a\.nupkg nuget-hosted-phx'

Also - it will be very helpful if you could provide a reproducer project with the yaml configuration and the nuget project in GitHub.

MichaelDenwood commented 4 years ago

I ran the command from the build agent machine exactly as ADO does, and it worked.

F:\Agents\SaaSProdW1_work_tool\jfrog\1.38.4\x64\jfrog.exe rt u F:\Agents\SaaSProdW1\_work\55\a\*.nupkg nuget-hosted-phx --url="https://artifacts.xxxx.com/artifactory" --user={Removed} --password={removed}

eyalbe4 commented 4 years ago

@MichaelDenwood - thanks for the additional information. Will you able to share with us a sample project that reproduces this issue, as @yahavi requested above?

MichaelDenwood commented 4 years ago

I was able to get permission to provide the actual project having the issue. @eyalbe4 and @yahavi have been invited to a repo on GH that contains a copy of the repo from ADO.

If you are not able to repro this, we can certainly set up a session over WebEx for you trouble shoot it in our environment.

wayofthepie commented 2 years ago

We are currently seeing this issue too. I'm just wondering if there was ever a resolution to this? Any info would be helpful really, it's a strange one! Thanks.