jfrog / jfrog-azure-devops-extension

Apache License 2.0
47 stars 65 forks source link

ArtifactoryNuget devops plugin is not pushing artifacts up anymore #242

Open killerjoe1990 opened 3 years ago

killerjoe1990 commented 3 years ago

Hello, we had a build working with the below config. All the sudden stopped working with latest version of plugin. Can you please help on why it is not pushing the nuget packages.

Old build indicating success: 2021-04-09T21:35:24.8491564Z ##[section]Starting: Artifactory Push 2021-04-09T21:35:24.8679887Z ============================================================================== 2021-04-09T21:35:24.8680321Z Task : Artifactory Nuget 2021-04-09T21:35:24.8680950Z Description : Restore and push NuGet packages from and to Artifactory while allowing to collect build-info. The collected build-info can be later published to Artifactory by the "Artifactory Publish Build Info" task. 2021-04-09T21:35:24.8682383Z Version : 1.11.2 2021-04-09T21:35:24.8682687Z Author : JFrog 2021-04-09T21:35:24.8683105Z Help : More Information 2021-04-09T21:35:24.8683614Z ============================================================================== 2021-04-09T21:35:25.3169593Z Downloading: https://api.bintray.com/content/jfrog/jfrog-cli-go/1.42.3/jfrog-cli-windows-amd64/jfrog.exe?bt_package=jfrog-cli-windows-amd64 2021-04-09T21:35:27.2123708Z Caching tool: jfrog 1.42.3 x64 2021-04-09T21:35:27.2917548Z Running jfrog-cli from C:\hostedtoolcache\windows\jfrog\1.42.3\x64\jfrog.exe. 2021-04-09T21:35:27.6555618Z JFrog CLI version: 1.42.3 2021-04-09T21:35:27.6921304Z 2021-04-09T21:35:27.6925299Z [Warn] You are using an old version of this task. 2021-04-09T21:35:27.6930947Z It is recommended to upgrade the task to its latest major version, 2021-04-09T21:35:27.6931897Z by replacing the task version in the azure-pipelines.yml file from 1 to 2, 2021-04-09T21:35:27.6932926Z or changing the task version from the task UI. 2021-04-09T21:35:27.6933187Z 2021-04-09T21:35:28.0864058Z [Info] [Thread 0] Uploading artifact: D:\a\1\a\EA.API.InstitutionFeatures.Client.1.0.15.nupkg 2021-04-09T21:35:28.0866331Z [Info] [Thread 2] Uploading artifact: D:\a\1\a\EA.API.InstitutionFeatures.Client.1.0.15.symbols.nupkg 2021-04-09T21:35:28.5803569Z { 2021-04-09T21:35:28.5804367Z "status": "success", 2021-04-09T21:35:28.5806379Z "totals": { 2021-04-09T21:35:28.5807088Z "success": 2, 2021-04-09T21:35:28.5807720Z "failure": 0 2021-04-09T21:35:28.5808284Z } 2021-04-09T21:35:28.5808965Z } 2021-04-09T21:35:28.6018723Z ##[section]Finishing: Artifactory Push

New build not working with debug on: 2021-04-16T17:14:05.4319110Z ##[debug]Evaluating condition for step: 'Artifactory Push' 2021-04-16T17:14:05.4321463Z ##[debug]Evaluating: and(succeeded(), eq(variables['Build.CreateRelease'], 'true')) 2021-04-16T17:14:05.4322091Z ##[debug]Evaluating and: 2021-04-16T17:14:05.4322595Z ##[debug]..Evaluating succeeded: 2021-04-16T17:14:05.4323503Z ##[debug]..=> True 2021-04-16T17:14:05.4323989Z ##[debug]..Evaluating eq: 2021-04-16T17:14:05.4324490Z ##[debug]....Evaluating indexer: 2021-04-16T17:14:05.4325027Z ##[debug]......Evaluating variables: 2021-04-16T17:14:05.4325824Z ##[debug]......=> Object 2021-04-16T17:14:05.4326437Z ##[debug]......Evaluating String: 2021-04-16T17:14:05.4327209Z ##[debug]......=> 'Build.CreateRelease' 2021-04-16T17:14:05.4327933Z ##[debug]....=> 'true' 2021-04-16T17:14:05.4328499Z ##[debug]....Evaluating String: 2021-04-16T17:14:05.4329186Z ##[debug]....=> 'true' 2021-04-16T17:14:05.4329645Z ##[debug]..=> True 2021-04-16T17:14:05.4330075Z ##[debug]=> True 2021-04-16T17:14:05.4330971Z ##[debug]Expanded: and(True, eq('true', 'true')) 2021-04-16T17:14:05.4331542Z ##[debug]Result: True 2021-04-16T17:14:05.4332213Z ##[section]Starting: Artifactory Push 2021-04-16T17:14:05.4453898Z ============================================================================== 2021-04-16T17:14:05.4454306Z Task : Artifactory Nuget 2021-04-16T17:14:05.4454919Z Description : Restore and push NuGet packages from and to Artifactory while allowing to collect build-info. The collected build-info can be later published to Artifactory by the "Artifactory Publish Build Info" task. 2021-04-16T17:14:05.4455502Z Version : 2.11.7 2021-04-16T17:14:05.4455752Z Author : JFrog 2021-04-16T17:14:05.4456164Z Help : More Information 2021-04-16T17:14:05.4456634Z ============================================================================== 2021-04-16T17:14:05.4608578Z ##[debug]Using node path: C:\agents\2.184.2\externals\node\bin\node.exe 2021-04-16T17:14:05.6783127Z ##[debug]agent.TempDirectory=D:\a_temp 2021-04-16T17:14:05.6808799Z ##[debug]loading inputs and endpoints 2021-04-16T17:14:05.6816585Z ##[debug]loading ENDPOINT_AUTH_2dbfcbe6-9550-4649-9a29-594bac7234a4 2021-04-16T17:14:05.6826769Z ##[debug]loading ENDPOINT_AUTH_PARAMETER_2dbfcbe6-9550-4649-9a29-594bac7234a4_PASSWORD 2021-04-16T17:14:05.6830486Z ##[debug]loading ENDPOINT_AUTH_PARAMETER_2dbfcbe6-9550-4649-9a29-594bac7234a4_USERNAME 2021-04-16T17:14:05.6832457Z ##[debug]loading ENDPOINT_AUTH_PARAMETER_SYSTEMVSSCONNECTION_ACCESSTOKEN 2021-04-16T17:14:05.6834312Z ##[debug]loading ENDPOINT_AUTH_SCHEME_2dbfcbe6-9550-4649-9a29-594bac7234a4 2021-04-16T17:14:05.6835861Z ##[debug]loading ENDPOINT_AUTH_SCHEME_SYSTEMVSSCONNECTION 2021-04-16T17:14:05.6837514Z ##[debug]loading ENDPOINT_AUTH_SYSTEMVSSCONNECTION 2021-04-16T17:14:05.6848723Z ##[debug]loading INPUT_ARTIFACTORYSERVICE 2021-04-16T17:14:05.6850728Z ##[debug]loading INPUT_BUILDNAME 2021-04-16T17:14:05.6852405Z ##[debug]loading INPUT_BUILDNUMBER 2021-04-16T17:14:05.6854191Z ##[debug]loading INPUT_COLLECTBUILDINFO 2021-04-16T17:14:05.6855736Z ##[debug]loading INPUT_COMMAND 2021-04-16T17:14:05.6857426Z ##[debug]loading INPUT_INCLUDEENVVARS 2021-04-16T17:14:05.6859069Z ##[debug]loading INPUT_NONUGETCACHE 2021-04-16T17:14:05.6861242Z ##[debug]loading INPUT_PACKAGESDIRECTORY 2021-04-16T17:14:05.6862410Z ##[debug]loading INPUT_PATHTONUPKG 2021-04-16T17:14:05.6865684Z ##[debug]loading INPUT_SOLUTIONPATH 2021-04-16T17:14:05.6866791Z ##[debug]loading INPUT_TARGETDEPLOYREPO 2021-04-16T17:14:05.6867632Z ##[debug]loading INPUT_VERBOSITYRESTORE 2021-04-16T17:14:05.6875981Z ##[debug]loading SECRET_BITBUCKET_PASSWORD 2021-04-16T17:14:05.6878494Z ##[debug]loading SECRET_DOTNET_NUGETPASSWORD 2021-04-16T17:14:05.6880804Z ##[debug]loading SECRET_SYSTEM_ACCESSTOKEN 2021-04-16T17:14:05.6892297Z ##[debug]loaded 22 2021-04-16T17:14:05.6915634Z ##[debug]Agent.ProxyUrl=undefined 2021-04-16T17:14:05.6916674Z ##[debug]Agent.CAInfo=undefined 2021-04-16T17:14:05.6919620Z ##[debug]Agent.ClientCert=undefined 2021-04-16T17:14:05.6920545Z ##[debug]Agent.SkipCertValidation=undefined 2021-04-16T17:14:05.7366906Z ##[debug]Agent.ProxyUrl=undefined 2021-04-16T17:14:05.7368028Z ##[debug]Agent.CAInfo=undefined 2021-04-16T17:14:05.7368924Z ##[debug]Agent.ClientCert=undefined 2021-04-16T17:14:05.7370107Z ##[debug]check path : D:\a_tasks\ArtifactoryNuGet_07fc5c20-6772-11e5-abde-6901d3d11476\2.11.7\node_modules\azure-pipelines-tool-lib\lib.json 2021-04-16T17:14:05.7371391Z ##[debug]adding resource file: D:\a_tasks\ArtifactoryNuGet_07fc5c20-6772-11e5-abde-6901d3d11476\2.11.7\node_modules\azure-pipelines-tool-lib\lib.json 2021-04-16T17:14:05.7372515Z ##[debug]system.culture=en-US 2021-04-16T17:14:05.7399253Z ##[debug]Agent.ToolsDirectory=C:\hostedtoolcache\windows 2021-04-16T17:14:05.7403708Z ##[debug]Agent.WorkFolder=D:\a 2021-04-16T17:14:05.7423487Z ##[debug]isExplicit: 1.46.2 2021-04-16T17:14:05.7424433Z ##[debug]explicit? true 2021-04-16T17:14:05.7425417Z ##[debug]Agent.Version=2.184.2 2021-04-16T17:14:05.7426379Z ##[debug]Agent.ToolsDirectory=C:\hostedtoolcache\windows 2021-04-16T17:14:05.7427379Z ##[debug]checking cache: C:\hostedtoolcache\windows\jfrog\1.46.2\x64 2021-04-16T17:14:05.7428294Z ##[debug]not found 2021-04-16T17:14:05.7463799Z ##[debug] 2021-04-16T17:14:05.7464838Z ##[debug]Agent.Version=2.184.2 2021-04-16T17:14:05.7465740Z ##[debug]Agent.TempDirectory=D:\a_temp 2021-04-16T17:14:05.7467497Z ##[debug]testing directory 'D:\a_temp' 2021-04-16T17:14:05.7506688Z Downloading: https://releases.jfrog.io/artifactory/jfrog-cli/v1/1.46.2/jfrog-cli-windows-amd64/jfrog.exe?bt_package=jfrog-cli-windows-amd64 2021-04-16T17:14:05.7507849Z ##[debug]destination D:\a_temp\3a9d7c95-fc85-4626-a379-ab61aa9436c8 2021-04-16T17:14:05.7508730Z ##[debug]downloading 2021-04-16T17:14:05.9308264Z ##[debug]creating stream 2021-04-16T17:14:06.1554902Z ##[debug]download complete 2021-04-16T17:14:06.1557713Z Caching tool: jfrog 1.46.2 x64 2021-04-16T17:14:06.1558849Z ##[debug]source file:D:\a_temp\3a9d7c95-fc85-4626-a379-ab61aa9436c8 2021-04-16T17:14:06.1560733Z ##[debug]Agent.Version=2.184.2 2021-04-16T17:14:06.1561715Z ##[debug]Agent.ToolsDirectory=C:\hostedtoolcache\windows 2021-04-16T17:14:06.1562741Z ##[debug]destination C:\hostedtoolcache\windows\jfrog\1.46.2\x64 2021-04-16T17:14:06.1563748Z ##[debug]rm -rf C:\hostedtoolcache\windows\jfrog\1.46.2\x64 2021-04-16T17:14:06.1566610Z ##[debug]rm -rf C:\hostedtoolcache\windows\jfrog\1.46.2\x64.complete 2021-04-16T17:14:06.1568337Z ##[debug]testing directory 'C:\hostedtoolcache\windows\jfrog\1.46.2\x64' 2021-04-16T17:14:06.1569453Z ##[debug]testing directory 'C:\hostedtoolcache\windows\jfrog\1.46.2' 2021-04-16T17:14:06.1570503Z ##[debug]testing directory 'C:\hostedtoolcache\windows\jfrog' 2021-04-16T17:14:06.1571480Z ##[debug]testing directory 'C:\hostedtoolcache\windows' 2021-04-16T17:14:06.1572424Z ##[debug]mkdir 'C:\hostedtoolcache\windows\jfrog' 2021-04-16T17:14:06.1573905Z ##[debug]mkdir 'C:\hostedtoolcache\windows\jfrog\1.46.2' 2021-04-16T17:14:06.1655384Z ##[debug]mkdir 'C:\hostedtoolcache\windows\jfrog\1.46.2\x64' 2021-04-16T17:14:06.1656810Z ##[debug]destination fileC:\hostedtoolcache\windows\jfrog\1.46.2\x64\jfrog.exe 2021-04-16T17:14:06.1869526Z ##[debug]Agent.Version=2.184.2 2021-04-16T17:14:06.1870784Z ##[debug]Agent.ToolsDirectory=C:\hostedtoolcache\windows 2021-04-16T17:14:06.1873816Z ##[debug]finished caching tool 2021-04-16T17:14:06.1875363Z ##[debug]Finished downloading JFrog cli. 2021-04-16T17:14:06.1876316Z Running jfrog-cli from C:\hostedtoolcache\windows\jfrog\1.46.2\x64\jfrog.exe. 2021-04-16T17:14:06.3562846Z JFrog CLI version: 1.46.2 2021-04-16T17:14:06.3572336Z ##[debug]command=push 2021-04-16T17:14:06.3574605Z ##[debug]which 'nuget' 2021-04-16T17:14:06.3934453Z ##[debug]found: 'C:\ProgramData\Chocolatey\bin\nuget.exe' 2021-04-16T17:14:06.3936314Z ##[debug]System.DefaultWorkingDirectory=D:\a\1\s 2021-04-16T17:14:06.7456902Z ##[debug]targetDeployRepo=bbnuget-local 2021-04-16T17:14:06.7460207Z ##[debug]targetDeployPath=undefined 2021-04-16T17:14:06.7462042Z ##[debug]pathToNupkg=D:\a\1\a*.nupkg 2021-04-16T17:14:06.7467295Z ##[debug]artifactoryService=2dbfcbe6-9550-4649-9a29-594bac7234a4 2021-04-16T17:14:06.7469244Z ##[debug]2dbfcbe6-9550-4649-9a29-594bac7234a4=https://transactcampus.jfrog.io/artifactory/ 2021-04-16T17:14:06.7474664Z ##[debug]2dbfcbe6-9550-4649-9a29-594bac7234a4 auth param username = 2021-04-16T17:14:06.7476829Z ##[debug]2dbfcbe6-9550-4649-9a29-594bac7234a4 auth param password = 2021-04-16T17:14:06.7478592Z ##[debug]2dbfcbe6-9550-4649-9a29-594bac7234a4 auth param apitoken = undefined 2021-04-16T17:14:06.7481630Z ##[debug]collectBuildInfo=true 2021-04-16T17:14:06.7537490Z ##[debug]buildName=android-desfire 2021-04-16T17:14:06.7538454Z ##[debug]buildNumber=1.0.14-CAMDEN-10517-v2.1 2021-04-16T17:14:06.7539771Z ##[debug]Executing cliCommand: C:\hostedtoolcache\windows\jfrog\1.46.2\x64\jfrog.exe rt u "D:\a\1\a\*.nupkg" "bbnuget-local" --url="https://transactcampus.jfrog.io/artifactory/" --user= --password= 2021-04-16T17:14:06.9510584Z { 2021-04-16T17:14:06.9511389Z "status": "success", 2021-04-16T17:14:06.9512976Z "totals": { 2021-04-16T17:14:06.9513487Z "success": 0, 2021-04-16T17:14:06.9514082Z "failure": 0 2021-04-16T17:14:06.9514582Z } 2021-04-16T17:14:06.9514992Z } 2021-04-16T17:14:06.9589986Z ##[debug]task result: Succeeded 2021-04-16T17:14:06.9592346Z ##[debug]Processed: ##vso[task.complete result=Succeeded;]Build Succeeded. 2021-04-16T17:14:06.9595423Z ##[debug]includeEnvVars=false 2021-04-16T17:14:06.9671069Z ##[section]Finishing: Artifactory Push

Config:

- task: ArtifactoryNuGet@2
  displayName: Artifactory Push
  inputs:
    command: push
    artifactoryService: MobileCredential.ServiceConnection.Artifactory
    targetDeployRepo: $(DotNet.NuGetPushRepo)
    pathToNupkg: $(Build.ArtifactStagingDirectory)/*.nupkg
    collectBuildInfo: true
    buildName: $(Build.DefinitionName)
    buildNumber: $(Build.BuildNumber)
  condition: and(succeeded(), eq(variables['Build.CreateRelease'], 'true'))

Going from ArtifactoryNuget@1 to ArtifactoryNuget@2 didnt fix the issue.

FYI nuget package is getting put in the right directory: Successfully created package 'D:\a\1\a\BbEA.API.Android.Desfire.1.0.14-camden-10517-v2-0003.nupkg'.

eyalbe4 commented 3 years ago

@killerjoe1990, Here's the jfrog-cli command from the logs you shared:

2021-04-16T17:14:06.7539771Z ##[debug]Executing cliCommand: C:\hostedtoolcache\windows\jfrog\1.46.2\x64\jfrog.exe rt u "D:\a\1\a\.nupkg" "bbnuget-local" --url="https://transactcampus.jfrog.io/artifactory/" --user=** --password=***

It looks like there's a missing character in "D:\a\1\a\.nupkg". It should actually be "D:\a\1\a\*.nupkg". Please let me know if the character hasn't been deleted by the pasting of the logs content. Can you try to replace

pathToNupkg: $(Build.ArtifactStagingDirectory)/*.nupkg

with:

pathToNupkg: *.nupkg

The result may shed some light on the issue.

killerjoe1990 commented 3 years ago

I tried what you suggested and that did not fix the issue. Still showing as success: "0"

This was working before and then recent changes broke it, I think the dev team needs to investigate why the devops plugin is no longer behaving with the CLI anymore. My guess is there is some mismatch happening between the plugin and the CLI but cannot confirm anything.

killerjoe1990 commented 3 years ago

The workaround for now is to use not use the ArtifactoryNuget plugin but instead use JFrogCli plugin directly:

- task: JfrogCli@1
  inputs:
    artifactoryService: MobileCredential.ServiceConnection.Artifactory
    command: 'jfrog rt u $(Build.ArtifactStagingDirectory)\*.nupkg  $(DotNet.NuGetPushRepo)'
  condition: and(succeeded(), eq(variables['Build.CreateRelease'], 'true'))
RobiNino commented 3 years ago

Hi @killerjoe1990 , We were unable to reproduce this issue, on either version of the task and with the two versions of the CLI. If this issue persists, additional information might help us finding the cause:

  1. The configuration of the resolve task.
  2. A .NET / Nuget project that reproduces this issue.

Thanks