Remove applicabilityScannable attribute for technology

jfrog / jfrog-cli-core

Apache License 2.0

32 stars 55 forks source link

Remove applicabilityScannable attribute for technology #1154

Open attiasas opened 4 months ago

attiasas commented 4 months ago

[x] All tests passed. If this feature is not already covered by the tests, I added new tests.
[x] All static analysis checks passed.
[x] This pull request is on the dev branch.
[x] I used gofmt for formatting the code before submitting the pull request.

This attribute is no longer needed. the new scanners will return a new status 'NOT_SCANNED' if not supported yet.

github-actions[bot] commented 4 months ago

[![👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerPR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)

[🐸 JFrog Frogbot](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)

hadarshjfrog commented 3 months ago

The code change itself looks good - my only concern - is how can we validate that when scanning a non-supported technology - just nothing well happened (as expected) - and not break anything?

Is it all handled here? https://github.com/jfrog/jfrog-cli-security/pull/37/files

jfrog / jfrog-cli-core

Remove applicabilityScannable attribute for technology #1154

[x] I used gofmt for formatting the code before submitting the pull request.