Move depTree logic out from 'xrayutils.go' file

jfrog / jfrog-cli-core

Apache License 2.0

33 stars 58 forks source link

Move depTree logic out from 'xrayutils.go' file #1180

Closed asafambar closed 4 months ago

asafambar commented 5 months ago

[X] All tests passed. If this feature is not already covered by the tests, I added new tests.
[X] All static analysis checks passed.
[X] This pull request is on the dev branch.
[X] I used gofmt for formatting the code before submitting the pull request.

asafambar commented 5 months ago

@eyalbe4 moved most logic from xrayutils to security repo, the file still have one function which is in use in the core project

eyalbe4 commented 5 months ago

@eranturgeman / @attiasas / @hadarshjfrog - Are you good with the removal of this code, and its addition to the jfrog-cli-security module? If so, I suggest we remove it only once the code is merged (or is about to be merged) to jfrog-cli-security, to allow us to release jfrog-cli at any point of time. Awaiting your green light to merge this.

eyalbe4 commented 4 months ago

Can we go ahead and merge this PR @attiasas? Would you like to merge the relevant code to jfrog-cli-security first?

jfrog / jfrog-cli-core

Move depTree logic out from 'xrayutils.go' file #1180

[X] I used gofmt for formatting the code before submitting the pull request.