jfrog / jfrog-cli

JFrog CLI is a client that provides a simple interface that automates access to the JFrog products.
https://www.jfrog.com/confluence/display/CLI/JFrog+CLI
Apache License 2.0
525 stars 223 forks source link

Unable to download LATEST artifact with `rt download --spec` with 1.51.0 and 1.51.1 #1220

Open trdyer opened 3 years ago

trdyer commented 3 years ago

Describe the bug When trying to pass a AQL spec file to download the latest versions of artifacts for multiple builds I am unable to use the LATEST parameter to get the most recent build. For instance

{
    "files": [{
        "pattern": "*",
        "build": "repo-a/main/LATEST",
        "target": "./",
        "flat": "true"
    }, {
        "pattern": "*",
        "build": "repo-b/main/LATEST",
        "target": "./",
        "flat": "true"
    }, {
        "pattern": "*",
        "build": "repo-c/main/LATEST",
        "target": "./",
        "flat": "true"
    }, {
      "pattern": "*",
      "build": "repo-d/LATEST",
      "target": "./",
      "flat": "false"
    }]
}

To Reproduce One thing I have noticed is that repo-a,b,c all have extraneous module ID's in the build as referenced in #1218 , and repo-d does not.

The artifacts for repo-d are successfully downloaded.

Expected behavior ALL artifacts are downloaded based on the AQL search.

Versions

Additional context This issue does not exist in 1.50.2

trdyer commented 2 years ago

This appears to still be the case with version 2.3.0 and Github Action: jfrog/setup-jfrog-cli@v2

sverdlov93 commented 2 years ago

@trdyer. Thanks for reporting this issue. It appears that the problem occurs when using LATEST parameter with build name that contains Slash (/) character. Behind the scenes, we escape slashes with %2F encoding, but it appears that AQL has a problem resolving the % character so the query fails to provide. Our apologies for the inconvenience caused by this bug. Resolving this issue requires changes on both Artifactory and JFrog CLI. We will share an update here once the fix is released.

We opened https://www.jfrog.com/jira/browse/RTFACT-25808 to track the required fix on Artifactory’s side.

rittneje commented 1 year ago

@sverdlov93 It's been a year. Is there any update on this bug?

daynemay commented 1 year ago

Can confirm still seeing this in 2.36.1

rittneje commented 1 year ago

@sverdlov93 @asafgabai @RobiNino What's the holdup here? The bug has been blocking our ability to upgrade beyond v1.50.2, including to your v2 CLI. You need to fix it.

eyalbe4 commented 1 year ago

Thanks @rittneje. We have re-added this task into our tasks backlog. We'll share an update here once progress is made.

Zoz24 commented 2 months ago

Still isn't fixed. At 2.59.1 now.