search

jfrog / jfrog-cli

JFrog CLI is a client that provides a simple interface that automates access to the JFrog products.
https://www.jfrog.com/confluence/display/CLI/JFrog+CLI
Apache License 2.0
533 stars 233 forks source link

Published scoped npm packages gets wrong path using JF CLI #2280

Open elumalaigjfrog opened 1 year ago

elumalaigjfrog commented 1 year ago

Describe the bug

I did create one scope package for testing and pushed two versions 1.0.0 and 2.0.0 to the local repo using both NPM and JF CLI respectively. The customer has seen a difference in path when it comes to scoped packages when pushed with JF CLI 2.50.2.

npm view @test/scoped-test@1.0.0 dist.tarball

http://localhost:8081/artifactory/api/npm/demo173/@test/scoped-test/-/@test/scoped-test-1.0.0.tgz

npm view @test/scoped-test@2.0.0 dist.tarball

http://localhost:8081/artifactory/api/npm/demo173/@test/scoped-test/-/scoped-test-2.0.0.tgz I can view the difference in the path when it comes to scoped packages and not regular ones.

Current behavior

I did create one scope package for testing and pushed two versions 1.0.0 and 2.0.0 to the local repo using both NPM and JF CLI respectively. The customer has seen a difference in path when it comes to scoped packages when pushed with JF CLI 2.50.2.

npm view @test/scoped-test@1.0.0 dist.tarball

http://localhost:8081/artifactory/api/npm/demo173/@test/scoped-test/-/@test/scoped-test-1.0.0.tgz

npm view @test/scoped-test@2.0.0 dist.tarball

http://localhost:8081/artifactory/api/npm/demo173/@test/scoped-test/-/scoped-test-2.0.0.tgz I can view the difference in the path when it comes to scoped packages and not regular ones.

Reproduction steps

Create a NPM scoped package Use JF CLI to publish the package.

Expected behavior

npm view @test/scoped-test@1.0.0 dist.tarball - npm client

http://localhost:8081/artifactory/api/npm/demo173/@test/scoped-test/-/@test/scoped-test-1.0.0.tgz

npm view @test/scoped-test@2.0.0 dist.tarball - JF CLI

http://localhost:8081/artifactory/api/npm/demo173/@test/scoped-test/-/scoped-test-2.0.0.tgz

I can view the difference in the path and it should be same.

JFrog CLI version

2.50.2

Operating system type and version

Mac

JFrog Artifactory version

No response

JFrog Xray version

No response

niklas2810 commented 1 year ago

I could reproduce this and face the same issue. It is important to point out though that the npm install for the package published via JFrog CLI still works, but it's still an inconvenience.

DiyanDev commented 11 months ago

I was also able to replicate this, publishing using the native "npm publish" command results in duplicate scope in the path.

Same as the example @elumalaigjfrog provided: //localhost:8081/artifactory/api/npm/demo173/@test/scoped-test/-/@test/scoped-test-1.0.0.tgz

That's not the case using jfrog-cli or the Artifactory plugin for Jenkins.

pauloazevedo88 commented 10 months ago

Any update on this topic? Having the same issue with local npm publish:

https://my.artifactory/artifactory/my-releases//**@my-team**/other/-/**@my-team**/other-test-0.0.16.tgz

joanna-polec commented 2 months ago

Hi, I have also encountered the same issue. Waiting for this fix.

wojtekkosowicz commented 2 months ago

Hey, having the same issue. Hoping for the fix soon.

connyay commented 1 month ago

👉 https://github.com/jfrog/build-info-go/pull/273