kaniko support - Githubissues

jfrog / jfrog-cli

JFrog CLI is a client that provides a simple interface that automates access to the JFrog products.

https://www.jfrog.com/confluence/display/CLI/JFrog+CLI

Apache License 2.0

531 stars 230 forks source link

kaniko support #804

Open johnmlwright opened 4 years ago

johnmlwright commented 4 years ago

Is your feature request related to a problem? Please describe. https://github.com/GoogleContainerTools/kaniko

kaniko is a tool to build container images from a Dockerfile, inside a container or Kubernetes cluster.

kaniko doesn't depend on a Docker daemon and executes each command within a Dockerfile completely in userspace. This enables building container images in environments that can't easily or securely run a Docker daemon, such as a standard Kubernetes cluster.

While kaniko is able to push images to Artifactory, there is no CLI support for kaniko.

Describe the solution you'd like to see JFrog CLI supports kaniko image pushing with build info.

Describe alternatives you've considered Push the image with kaniko to Artifactory, then download the image outside of the kaniko container, where the daemon exists. From there, upload the image with buildInfo using CLI.

tanguydelignieresaccenture commented 3 years ago

See jenkins-artifactory-plugin #320 I commented about this:

I'm in the same context (kaniko pushing the layers to artifactory itself and not the jfrog cli with build info). In fact a build info must be published in order to run an XRay scan.

So I'm trying a workaround:

Using jfrog-cli set-props, after kaniko has push layers of image to artifactory, to set the properties build.name and build.number on artifacts (it's needed in order for the build info to match the artifacts, see here)
Creating a build info json file locally using pushed layers properties via jfrog-cli search + jq following the build info format
Creating the build info on artifactory side via this undocumented private REST API
Calling the jfrog-cli build-scan on my build

I confirm I was able to make an XRay scan of an already pushed image and its layers, this way. But thinking of the complexity of this sequence, there should be a feature to achieve this as this is a real use case.

eyalbe4 commented 3 years ago

Thank you all for raising this requirement. This definitely needs to be supported. This feature has been added into our plan and we'll soon start working on implementing this. We'll keep this GitHub issue up to date with our progress.

Or-Geva commented 3 years ago

@johnmlwright and @tanguydelignieresaccenture, JFrog-CLI v1.43.0 is released which includes support for collecting build-info for Kaniko. Here is a project example of how to use it with docker-client.

DS-KrzJon commented 2 years ago

https://github.com/jfrog/project-examples/tree/master/docker-oci-examples/kaniko-example is the new repo for example