search

jfrog / jfrog-client-go

All go clients for JFrog products
Apache License 2.0
255 stars 136 forks source link

The Xray APIs should not use ArtifactoryClientBuilder #224

Closed eyalbe4 closed 3 years ago

eyalbe4 commented 3 years ago

Describe the bug Following the merge of https://github.com/jfrog/jfrog-client-go/pull/211 we should refactor the code, so that the new Xray APIs introduced in this PR do not use the ArtifactoryClientBuilder. We should either create a generic builder for all JFrog services, or alternatively create client APIs for Xray. See the following comment as part of the above PR:

Now that ArtifactoryClientBuilder also needs to be used for Xray, we should rename it to HttpClientBuilder. We should also move the httpclient package, which is currently located under the artifactory directory, to be one level up, next to the artifactory dir. rthttpclient should be renamed to httpclient, or if the the httpclient is already taken as an alias in the file, maybe jfroghttpclient.

To Reproduce N/A

Expected behavior N/A

Screenshots N/A

Versions

eyalbe4 commented 3 years ago

https://github.com/jfrog/jfrog-client-go/pull/255 resolves this issue.