jfrog / jfrog-client-go

All go clients for JFrog products
Apache License 2.0
260 stars 139 forks source link

SBOM ingestion #961

Closed barv-jfrog closed 1 month ago

barv-jfrog commented 2 months ago

The point of this PR is part of 3 PRs that enable the command "jf sbom-enrich" which takes XML/JSON of a CycloneDX SBOMs of packages/dockers, sends it to XRAY for scanning (to find vulnerabilities) and print out the input (which is xml/json cyclonedx) with vulnerabilities section that was found in XRAY. It basically uses a new API that can digest these new formats, but it still uses GraphScan and ExportGraphScan which are pre-existing APIs. That's why there are some similarities between the two.

github-actions[bot] commented 2 months ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

barv-jfrog commented 2 months ago

I have read the CLA Document and I hereby sign the CLA

barv-jfrog commented 2 months ago

The point of this PR is part of 3 PRs that enable the command "jf sbom-enrich" which takes XML/JSON of a CycloneDX SBOMs of packages/dockers, sends it to XRAY for scanning (to find vulnerabilities) and print out the input (which is xml/json cyclonedx) with vulnerabilities section that was found in XRAY. It basically uses a new API that can digest these new formats, but it still uses GraphScan and ExportGraphScan which are pre-existing APIs. That's why there are some similarities between the two.

barv-jfrog commented 2 months ago
  • Add description to the PR
  • Change the README.md to include those changes.
  • Add tests at tests for the new service

Added description and changed README.md to include those changes. Regarding tests - I use similar functions to Scan just with different XRAY Api. I have not seen tests for these functions in scan service. @attiasas

github-actions[bot] commented 1 month ago
[![👍 Frogbot scanned this pull request and did not find any new security issues.](https://raw.githubusercontent.com/jfrog/frogbot/master/resources/v2/noVulnerabilityBannerPR.png)](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)

[🐸 JFrog Frogbot](https://docs.jfrog-applications.jfrog.io/jfrog-applications/frogbot)