Fix to close response body before status check

[nakabonne]

httpclient.HttpClient.UploadFileFromReader() used to not to close the HTTP response body when the status code is unexpected. The defer block for this should be appended right after the HTTP call is made.

• [x] All tests passed. If this feature is not already covered by the tests, I added new tests.
• [x] All static analysis checks passed.
• [x] This pull request is on the dev branch.

• [x] I used gofmt for formatting the code before submitting the pull request.

[github-actions[bot]]

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

[nakabonne]

I have read the CLA Document and I hereby sign the CLA

[sverdlov93]

Hi @nakabonne, Thanks for your contribution!

[nakabonne]

@sverdlov93 Thank you for your quick review! We're stuck with the goroutine leak issue because of this. Can you estimate approximately when this will be released?

[sverdlov93]

Hi @nakabonne,

Do you need this as part of the JFrog CLI, or do you use jfrog-client-go as a dependency?

[nakabonne]

@sverdlov93 We use jfrog-client-go as a dependency in our Go project.

[sverdlov93]

@nakabonne Its released! Thanks again for your contribution!

[nakabonne]

Thank you for the quick release and for maintaining this project!