jfrog / jfrog-client-js

Xray Javascript Client
Apache License 2.0
13 stars 14 forks source link

Axios outdated. Please bump. #93

Open nl-brett-stime opened 8 months ago

nl-brett-stime commented 8 months ago

Getting a security ding because of our dependence on jfrog-client-js:

image

attiasas commented 8 months ago

Hi @nl-brett-stime, thank you for bringing this matter to our attention.

Once Axios resolves the proxy issue, i.e., after one of the following occurrences:

Merging of https://github.com/axios/axios/pull/6091 into v0 Resolution of https://github.com/axios/axios/issues/4840 in v1

we'll proceed with the upgrade to the "fixed version".

DanieloDelgado commented 7 months ago

Hi @attiasas , axios v0.28.0 was released last week. This version includes https://github.com/axios/axios/pull/6091. You can proceed with releasing a new version with the fix for CVE-2023-45857

jvillanuevabt commented 6 months ago

Is there any update/ETA on this being resolved?

asafcjfrog commented 6 months ago

@jvillanuevabt As mentioned above by @attiasas , the CVE is not applicable. So, this is considered a low priority. Please let me know if you have any concerns.

jvillanuevabt commented 6 months ago

@jvillanuevabt As mentioned above by @attiasas , the CVE is not applicable. So, this is considered a low priority. Please let me know if you have any concerns.

I understand, my only concern is leaving a known vulnerable dependency unpatched indefinitely given it is considered good practice to update dependencies whenever possible. Of course there is no rush but I was hoping for an ETA on when that update will happen.