search

jfrog / jfrog-ecosystem-integration-env

A Docker image containing all the tools JFrog CLI integrates with and supports.
Apache License 2.0
13 stars 13 forks source link

Nvm: Node Version Manager #37

Open marcandre-larochelle-bell opened 1 year ago

marcandre-larochelle-bell commented 1 year ago

Hi,

Similar to https://github.com/jfrog/jfrog-ecosystem-integration-env/issues/36

In the case of the JFrog Cli, it would allow to install other versions of Node JS (more recent) to scan the dependencies of projects using more recent version.

See: https://github.com/nvm-sh/nvm#nvmrc

It can also automatically detect which version it needs via the .nvmrc file.

Thanks in advance.

eyalbe4 commented 1 year ago

Hi @marcandre-larochelle-bell, Would you like to contribute the above additions through a pull request?

marcandre-larochelle-bell commented 1 year ago

Hi @eyalbe4 sorry for not replying in a fastly manner, was very busy.

The issue I see by doing it myself, it involves modifying the entrypoint of the dockerfile and I am unsure of the scope of images this could affect here. (Specifically to support non-interactive shells as well)

I personally did it in my own image which depends on the CLI image.