jfrog / kubexray

JFrog KubeXray scanner on Kubernetes
Apache License 2.0
25 stars 9 forks source link

whitelistNamespaces in values.yaml should be 1 level up #2

Closed ankushchadha closed 5 years ago

ankushchadha commented 5 years ago

What? whitelistNamespaces in values.yaml should be global and probably directly under scanPolicy.

Why? whitelistNamespaces is applicable to all policies. In the default values.yaml it is not clear that this key is applicable to all policies or only the unscanned ones.

Existing sample -

scanPolicy: unscanned:

Set for unscanned deployments delete/scaledown/ignore

deployments: ignore
# Set for unscanned statefulsets delete/scaledown/ignore
statefulSets: ignore
# Whitelist namespaces
whitelistNamespaces: "kube-system,kube-xray"
rimusz commented 5 years ago

addressed in #5