Closed karolh2000 closed 3 years ago
CLA Assistant Lite bot All contributors have signed the CLA ✍️
I have read the CLA Document and I hereby sign the CLA
@peters95 John, @MahithaB Mahitha. Please take a look and my findings/suggestions/changes. If you are OK with the changes and the script then great if not or additional work is needed please let me know. These changes are merely suggestions for what would be in in my opinion useful to make the process smoother. Thanks
This pull request is meant to improve the log analytics installation experience. The changes in the PR should be treated as suggestions as I’m not very familiar with the log-analytics functionality. The PR contains the following changes:
Interactive Fluentd installer with the following functionality:
Changes in the log-analytics README.md.
General comments not directly related/included to the PR changes.
[Splunk repo] - https://github.com/jfrog/log-analytics-splunk README.md
“Configure HEC to accept data” - this steps should mention to write down the HEC port used later the steps (default is 8088)
“Configure new HEC token” - this doesn't sound right?:
“Splunk App” - JFrog app can be installed directly from the Splunk store instead of a file (app) that needs to be uploaded/installed later so some steps could be removed.
[Elastic] - https://github.com/jfrog/log-analytics-elastic
[Prometheus] - https://github.com/jfrog/log-analytics-prometheus
General comments that apply to all README.md/steps
Please let me know if you have any questions.