jfrog / teamcity-artifactory-plugin

TeamCity plugin that enables traceable build artifacts with Artifactory
https://www.jfrog.com/confluence/display/JFROG/TeamCity+Artifactory+Plug-in
Apache License 2.0
42 stars 48 forks source link

Restore SCM URL after release is completed: AgentListenerReleaseHelper.java #7

Open tatchiuleung opened 10 years ago

tatchiuleung commented 10 years ago

Hi @shayke,

https://github.com/JFrogDev/teamcity-artifactory-plugin/blob/2401e170ea0062de336a4942b2606aabd298cc13/agent/src/main/java/org/jfrog/teamcity/agent/listener/AgentListenerReleaseHelper.java

Line 129: for (Map.Entry<ModuleName, File> pomEntry : projectPoms.entrySet()) { PomTransformer transformer = new PomTransformer(pomEntry.getKey(), versionsByModule, releaseParams.isSvn() ? releaseParams.getTagUrl() : null, releaseVersion);

        vcsCoordinator.edit(pomEntry.getValue());
        modified |= transformer.transform(pomEntry.getValue());
    }

Can we do something here so that if releaseVersion is false, it restores to the original URL (e.g. trunk)? The plugin messed up the scm URLs and I always have to change it back to trunk manually before doing any maven scm goals.

Thank you.