jfrog / terraform-provider-platform

Terraform provider to manage JFrog Platform
https://jfrog.com
Apache License 2.0
1 stars 2 forks source link

Missing MyJFrog API Token warning when not specified #132

Open mymasse opened 2 weeks ago

mymasse commented 2 weeks ago

Describe the bug When not specifying the deprecated myjfrog_api_token in the provider configuration or using JFROG_MYJFROG_API_TOKEN environment variable a warning will be printed all the time.

Sample configuration

terraform {
  required_version = ">= 1.0"  
  required_providers {    
    platform = {
      source  = "jfrog/platform"
      version = "1.12.0"
    }
  }
}

provider "platform" {
  url          =  <VALID URL>
  access_token = <VALID ACCESS TOKEN>
}

Requirements for and issue

Versions Artifactory: 7.90.13 Terraform: 1.9.6 Provider: 1.12.0

Expected behavior If this argument is deprecated why even print a warning if not used.

Additional context N/A

alexhung commented 2 weeks ago

@mymasse Deprecating an attribute is a multi-steps process. The first step is to mark the attribute as 'deprecated' whilst retaining all functionality. The next step is to remove functionality with next major release and remove the attribute altogether.

So expect the warning message be gone in next major release.

See Terraform doc for reference.