search

jfrog / terraform-provider-xray

Terraform provider to manage JFrog Xray
https://jfrog.com/xray/
Apache License 2.0
149 stars 12 forks source link

licenses endpoint 400 response #22

Closed codebop closed 2 years ago

codebop commented 2 years ago

I'm a JFrog customer with the following license info: { "type" : "Enterprise", "validThrough" : "N/R", "licensedTo" : "Artifactory Online Dedicated", "subscriptionType" : "enterprise_xray_team" }

When I try to use this provider I get the following error: Error: 400 GET https://opploans.jfrog.io/artifactory/api/system/licenses/ { "errors" : [ { "status" : 400, "message" : "Artifactory Online does not require license, Please contact support@jfrog.com for further assistance if required." } ] }

If I change https://github.com/jfrog/terraform-provider-xray/blob/94fbbb8fc22d715ffbd744222e7ebfcc9165b5d1/pkg/xray/provider.go#L158 to be _, err := client.R().SetResult(&license).Get("/artifactory/api/system/license/") (singular), and re-install the provider it works without error. The JFrog API docs reference "/licenses" not "/license" so I'm not sure if the docs are wrong or what's up with that.

danielmkn commented 2 years ago

That's interesting. The documentation for that call is here. The singular form is not mentioned there. We will check with the core product team after the weekend and let you know. Thanks!

danielmkn commented 2 years ago

SaaS instances have different license API endpoint than On-Prem. And, unfortunately, it's not documented. We will fix it this week.

danielmkn commented 2 years ago

Hi @codebop, it's fixed. Also, we've fixed the documentation. Thanks for the contribution!