parse time in local tz - Githubissues

jfrog / terraform-provider-xray

Terraform provider to manage JFrog Xray

https://jfrog.com/xray/

Apache License 2.0

149 stars 12 forks source link

parse time in local tz #238

Closed ritzk closed 3 weeks ago

ritzk commented 3 weeks ago

resolve #237

Test env ( on alpine)

Set tz to EST

$ date
XXX UTC 2024

$ apk tzdata
$ ln -sf /usr/share/zoneinfo/America/New_York /etc/localtime

$ date
XXX EDT 2024

opentofu 1.8.2 (ghcr.io/opentofu/opentofu)
terraform 1.9.5 ( docker.io/hashicorp/terraform)

What is tested

client and server have same tz
server and client have different tz ( client tz is mapped to server tz )

Actual results: Without this tz is parsed in UTC regardless of local tz

Expected result tz should parsed in local tz, or provide the option to specify time with tz ( 2024-11-01T13:00-04:00/ 2024-11-01T13:00Z/...)

github-actions[bot] commented 3 weeks ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

ritzk commented 3 weeks ago

I have read the CLA Document and I hereby sign the CLA

ritzk commented 3 weeks ago

Look ok. Please add a test for the tz use case in https://github.com/jfrog/terraform-provider-xray/blob/main/pkg/xray/resource/resource_xray_ignore_rule_test.go

@alexhung not familiar enough with go to write a test case for this usecase.

alexhung commented 3 weeks ago

@ritzk Ok no problem. I'll add that once this is merged.