search

jfrog / terraform-provider-xray

Terraform provider to manage JFrog Xray
https://jfrog.com/xray/
Apache License 2.0
151 stars 12 forks source link

Remove default build_failure_grace_period_in_days #29

Closed ltran-spirent closed 2 years ago

ltran-spirent commented 2 years ago

API expects this value to only be set when fail_build is set to true. But because there isa default value of 3 and when a fail_build is set to false OR not set at all, it errors out out.

github-actions[bot] commented 2 years ago

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request

danielmkn commented 2 years ago

Thanks, @ltran-spirent! Please remove the default value from the security policy as well, here and I'll merge a PR

danielmkn commented 2 years ago

Also, please sign a CLA, as described in the comment above.

danielmkn commented 2 years ago

@ltran-spirent you need to sight CLA before I can merge the PR. Please add a comment with the following wording: I have read the CLA Document and I hereby sign the CLA

chb0github commented 2 years ago

This should also be an issue so it can be searched

chb0github commented 2 years ago

This logic can't be captured by TF directly - However, it can be implemented in code and should be.

danielmkn commented 2 years ago

@ltran-spirent I have to close this PR, CLA is not signed. I've made the changes in another branch, #30