License requirements

[fmalykh]

Describe the bug Hi there, We have a Commercial type Artifactory license with X-Ray functionality up and running:

{
  "type" : "Commercial",
  "validThrough" : "Apr 22, 2023",
  "licensedTo" : "Redacted"
}

Are we eligible to use this terraform provider?

Error: Artifactory Projects requires Enterprise license to work with Terraform!

We have no issues using https://github.com/jfrog/terraform-provider-artifactory which allows setting check_license = false: https://registry.terraform.io/providers/jfrog/artifactory/latest/docs#check_license

[danielmkn]

Thanks, @fmalykh, I'm looking into it!

[chb0github]

@alexhung - This was recently fixed and moved to our common stuff - I think @danielmkn all that's required is bumping the dependency

[chb0github]

@fmalykh - you can also disable license check

check_license = false

[danielmkn]

yup, I see the change. I don't use it in the Xray provider. I'll add Commercial to the list today.

[fmalykh]

@chb0github I tried before submitting this but it's an invalid option

terraform -version
Terraform v0.14.5
+ provider registry.terraform.io/jfrog/artifactory v6.7.2
+ provider registry.terraform.io/jfrog/xray v1.1.3

terraform plan

Error: Unsupported argument

  on main.tf line 10, in provider "xray":
  10:   check_license = false

An argument named "check_license" is not expected here.

[danielmkn]

Hold on, fix is on the way.

[chb0github]

@danielmkn - it would be better to just use that shared code since it's common to other providers and we're trying to get consistent with all of them

[danielmkn]

@fmalykh, released in 1.1.4!

[fmalykh]

worked like a charm! lightning fast! thanks!