Draft: feat: rotate admin token

jfrog / vault-plugin-secrets-artifactory

HashiCorp Vault Secrets Plugin for Artifactory

https://jfrog.com

Apache License 2.0

41 stars 20 forks source link

Draft: feat: rotate admin token #16

Closed TJM closed 1 year ago

TJM commented 2 years ago

Closes #14

This should setup the ability to "rotate" the admin token after setting it. This means that we can immediately revoke the admin token that was "known" (at least by the pipeline script), and only Vault itself will know the admin token it is using.

This has not been fully tested, this is a request for "review" and comments.

github-actions[bot] commented 2 years ago

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

TJM commented 2 years ago

I have read the CLA Document and I hereby sign the CLA

TJM commented 2 years ago

I will close this PR, as it is superseded by #17

alexhung commented 1 year ago

@TJM If #17 superseded this PR, please close this one.

TJM commented 1 year ago

Closing.