jfrog / vault-plugin-secrets-artifactory

HashiCorp Vault Secrets Plugin for Artifactory
https://jfrog.com
Apache License 2.0
42 stars 21 forks source link

feat: real artifactory for local testing #44

Closed TJM closed 1 year ago

TJM commented 1 year ago

This uses the artifactory-jcr container to create a local dev artifactory instance.

It also uses the magic scripts (with some edits) from the terraform provider to get an access key.

Closes #38

TJM commented 1 year ago

The script we liberated from the terraform module doesn't work on Artifactory older than 7.21. I don't know if we care, that is like Dec 2021, right? For what its worth, the "make setup" does work if you set a valid JFROG_ACCESS_TOKEN variable, but we get 404 codes if we try to generate a user token on that version... so we have to ask ourselves whether we care to support that version or not... I am leaning towards not? :)

alexhung commented 1 year ago

The script we liberated from the terraform module doesn't work on Artifactory older than 7.21. I don't know if we care, that is like Dec 2021, right?

That's far too old a version for us (i.e. me and my team) to support. In general, our strategy is to only support the latest released version. There will be exception(s) when breaking changes/deprecation happens.

TJM commented 1 year ago

Should I compress the changes to one commit or can you do that on merge?

alexhung commented 1 year ago

@TJM I'm indifferent to how the git history look. If you prefer to clean up the commit history, go ahead. I'm fine either way 😄

TJM commented 1 year ago

@alexhung rebased, same code, but it will need re-approval. Thanks in advance ;)

alexhung commented 1 year ago

Waiting for @shrajfr12 review before merging and releasing.