search

jfrog / vault-plugin-secrets-artifactory

HashiCorp Vault Secrets Plugin for Artifactory
https://jfrog.com
Apache License 2.0
42 stars 21 forks source link

Allow for "username" parameter on /config/rotate to change token username #69

Closed TJM closed 1 year ago

TJM commented 1 year ago

We have just changed all of our admin tokens from the username "admin" to "${VAULT_NAMESPACE}-vault-admin," and had to do it all "by hand" (as in generate the new admin token and vault write artifactory/config/admin access_token=$NEW_TOKEN. It might be nice if people could specify a username parameter to the /config/rotate endpoint, allowing them to set/change the username for the admin token.

TJM commented 1 year ago

While doing this, might as well allow description field as well.

EDIT: Also, I tagged the wrong issue in #78, so its a good thing it didn't auto-close :p