jfromaniello / express-unless

Conditionally add a middleware to express with some common patterns
MIT License
178 stars 27 forks source link

Possible "custom" option missing ? #35

Closed TitaneBoy closed 2 years ago

TitaneBoy commented 2 years ago

Hi there. Since the last released version of express-unless (2.1.0), it seems that the "custom" option is missing in the package. At least, the "custom" option seems to be missing in the "Type definition" of the package

image

image

Also, the documentation seems to say that this option must be available

image

Thank you for your help

johnciprian commented 2 years ago

I'm also running into this problem

jfromaniello commented 2 years ago

Fixed in v2.1.1. Thanks for reporting this

johnciprian commented 2 years ago

Fixed in v2.1.1. Thanks for reporting this

Thanks! I'll look out for when it gets released to NPM.

TitaneBoy commented 2 years ago

@jfromaniello : Thanks a lot for the fix. But unless I am missing something, it looks that version v2.1.1 is not yet published in npm, but it is tagged in github. Is it possible you've forget to publish this version or there is a reason why it is not yet published in npm ?

image

Thanks in advance

jfromaniello commented 2 years ago

sorry about that, it is published now. Thanks for the heads up