search

jfromaniello / selfsigned

Generate self-signed certificates from node.js
MIT License
237 stars 53 forks source link

v1.3.0 is a breaking change via node-forge upgrade in node < 10: "ReferenceError: URLSearchParams is not defined" #50

Closed billneff79 closed 2 years ago

billneff79 commented 2 years ago

If you are running node < 10, the upgrade to node-forge 1.x contained in selfsigned@1.3.0 produces the following error because URLSearchParams is not natively supported:

/Users/bneff/repos/blocks/node_modules/selfsigned/node_modules/node-forge/lib/log.js:305
    query = new URLSearchParams();
    ^

ReferenceError: URLSearchParams is not defined
    at Object.<anonymous> (/Users/bneff/repos/blocks/node_modules/selfsigned/node_modules/node-forge/lib/log.js:305:5)
    at Module._compile (internal/modules/cjs/loader.js:654:30)

Upgrading node-forge to 1.x should have been a major change in selfsigned

devmubeen commented 2 years ago

Anyone checked this issue?

reachmehere89 commented 2 years ago

Same issue

ahmedHusseinF commented 2 years ago

Same issue, i think you should upgrade the major version not just a patch, because this is a breaking change in node-forge

jfromaniello commented 2 years ago

😫 my bad, ok I will publish a major version and a patch reverting the patch. Does that sounds good?

jfromaniello commented 2 years ago

ok, now I published: