search

jfromaniello / selfsigned

Generate self-signed certificates from node.js
MIT License
237 stars 53 forks source link

Add @types/node-forge dependency #64

Closed aomarks closed 11 months ago

aomarks commented 2 years ago

The new selfsigned types reference node-forge, but since @types/node-forge isn't listed as a dependency, users will hit the following error:

node_modules/selfsigned/index.d.ts:1:21 - error TS7016: Could not find a declaration file for module 'node-forge'. '/home/aomarks/work/wireit/node_modules/node-forge/lib/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/node-forge` if it exists or add a new declaration (.d.ts) file containing `declare module 'node-forge';`

1 import { pki } from 'node-forge'
                      ~~~~~~~~~~~~

Adding the dependency solves that problem.

Thank you!

jfromaniello commented 11 months ago

Thank you and sorry for the long delay 🙏🏽 . It should be fixed in v2.3.0