Open tblaudez opened 14 hours ago
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard. Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Edit: Changed base from dev to master since I edited from this branch
Could you please target dev
instead of master
so the changes here will be part of next release?
I try to keep the master
branch tied to releases so newcomers or people who want stability have all tested/validated/documented changes only in master. No problem if the change originates from master as they are no breaking changes.
Actually I can target dev
myself :)
Sure thing ! I'll keep it in mind for the next PRs and use dev as the source branch.
Add a progress indicator to the configuration loop in run-seedbox.sh I added this to avoid frustration when running the script is lengthy (especially when my VPS in under heavy load).
The JSON configuration is put in a variable casted a as Bash array so that we can still loop over it AND retrieve its length. Another variable is added to count the current iteration of the loop.
Using this information, we use printf to add a new output line with constant width that indicates the current progress. This line is being constantly overwritten by each iteration thanks to the carriage return and the constant width. When we are on the last iteration of the loop; we break out of the progress line by adding a sole newline.